Add Block Kit layout to frontend-triage notifications - #6677
Conversation
9487ac3 to
61f1aec
Compare
61f1aec to
24eaad0
Compare
There was a problem hiding this comment.
Pull request overview
This pull request implements Slack Block Kit formatting for the frontend-triage agent’s auto-apply notifications, improving readability while preserving the existing plain-text message as Slack’s fallback.
Changes:
- Refactors notification rendering into small helpers (
_bug_link,_summary,_is_urgent, field renderers). - Adds
build_blocks(...)to generate a Block Kit layout (headline, optional fields grid, run context). - Updates notification recording and tests to ensure
blocksis included and that Block Kit conveys at least the same facts/URLs as the fallback text.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| agents/frontend-triage/hackbot_agents/frontend_triage/notify.py | Adds Block Kit block building and records Slack actions with both text and blocks. |
| agents/frontend-triage/tests/test_notify.py | Extends tests to validate Block Kit structure and equivalence of conveyed facts vs fallback text. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
@suhaibmujahid #6679 removes the triage agent's ability to write After #6679 lands, this would need a rebase plus a couple of changes:
A few tests in this PR assume the old behaviour too, but those should fail loudly on the rebase so they're easy to spot. |
msujaws
left a comment
msujaws
left a comment
There was a problem hiding this comment.
I tested this out and it looks good. We may want to change how some of the blocks are positioned and what is in them after we live with this for a while but I don't want to force perfection on the first pass here. Thank you!
24eaad0 to
42eded7
Compare
42eded7 to
4a125c2
Compare
4a125c2 to
5606a0d
Compare
Refactors notification rendering into reusable helpers and adds `build_blocks` for richer Slack messages.
5606a0d to
9bbaad3
Compare
Resolves #6673
Refactors notification rendering into reusable helpers and adds
build_blocksfor richer Slack messages.Stack created with GitHub Stacks CLI • Give Feedback 💬